Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger proxies for resilience strategies #1379

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 3, 2023

Details on the issue fix or feature implementation

Simplifies the debugging. Contributes to #1367

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 3, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1379 (bf9b9e7) into main (870d053) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   83.60%   83.63%   +0.03%     
==========================================
  Files         267      269       +2     
  Lines        6397     6411      +14     
  Branches     1002     1004       +2     
==========================================
+ Hits         5348     5362      +14     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.63% <100.00%> (+0.03%) ⬆️
windows 83.63% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Core/ResilienceStrategy.TResult.Async.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/ResilienceStrategyPipeline.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.DebuggerProxy.cs 100.00% <100.00%> (ø)
...y.Core/ResilienceStrategy.TResult.DebuggerProxy.cs 100.00% <100.00%> (ø)

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Do you have some screenshots of how this appears in the debugger?

src/Polly.Core/ResilienceStrategy.DebuggerProxy.cs Outdated Show resolved Hide resolved
src/Polly.Core/ResilienceStrategy.TResult.DebuggerProxy.cs Outdated Show resolved Hide resolved
@martintmk
Copy link
Contributor Author

Nice!

Do you have some screenshots of how this appears in the debugger?

image

When you expand it it will show the list of strategies inside.

@martintmk martintmk enabled auto-merge (squash) July 3, 2023 07:43
@martintmk martintmk merged commit 158a2f8 into main Jul 3, 2023
@martintmk martintmk deleted the mtomka/debuggerproxies branch July 3, 2023 08:17
@martincostello
Copy link
Member

Just playing with this and it's not quite right - if you expand the pipeline to see what it's composed of, then each individual item just repeats forever.

I don't seem to be able to get VS to take a screenshot without hiding the debugger tooltip though 😄

@martintmk
Copy link
Contributor Author

@martincostello, checked the behavior too and it's strange. Let me try to address it.

@martintmk martintmk mentioned this pull request Jul 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants