Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced nesting levels through block-scoped usings and the inversion of an if block. #1453

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Aug 3, 2023

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature (N/A)
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1453 (df694c9) into main (77e91d5) will increase coverage by 0.02%.
The diff coverage is 90.42%.

@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
+ Coverage   83.90%   83.92%   +0.02%     
==========================================
  Files         273      273              
  Lines        6516     6506      -10     
  Branches     1012     1012              
==========================================
- Hits         5467     5460       -7     
+ Misses        840      837       -3     
  Partials      209      209              
Flag Coverage Δ
linux 83.92% <90.42%> (+0.02%) ⬆️
macos 83.92% <90.42%> (+0.02%) ⬆️
windows 83.92% <90.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ircuitBreaker/ConsecutiveCountCircuitController.cs 84.00% <78.94%> (+1.85%) ⬆️
.../Polly/CircuitBreaker/AdvancedCircuitController.cs 88.23% <81.81%> (-0.96%) ⬇️
src/Polly/Timeout/TimeoutEngine.cs 96.00% <95.45%> (ø)
src/Polly/CircuitBreaker/CircuitStateController.cs 93.93% <100.00%> (-0.18%) ⬇️
src/Polly/Timeout/AsyncTimeoutEngine.cs 92.59% <100.00%> (+6.38%) ⬆️

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@martincostello martincostello merged commit 0f38c51 into App-vNext:main Aug 4, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants