Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1687 - Make ResilienceContextPool settable via DI #1693

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

cmeyertons
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1687

Details on the issue fix or feature implementation

Followed @martintmk suggestion to make ResilientContextPool settable via DI pipeline

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e869fe8) 84.63% compared to head (9f363a4) 84.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   84.63%   84.65%   +0.02%     
==========================================
  Files         306      306              
  Lines        6819     6829      +10     
  Branches     1045     1046       +1     
==========================================
+ Hits         5771     5781      +10     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.65% <100.00%> (+0.02%) ⬆️
macos 84.65% <100.00%> (+0.02%) ⬆️
windows 84.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Core/Registry/RegistryPipelineComponentBuilder.cs 100.00% <100.00%> (ø)
...ore/Registry/ResiliencePipelineRegistry.TResult.cs 100.00% <100.00%> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/ResiliencePipelineBuilder.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineBuilder.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineBuilderBase.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineT.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I'll leave the other Martin to give a 👍 or 👎

src/Polly.Core/ResiliencePipelineBuilderBase.cs Outdated Show resolved Hide resolved
src/Polly.Core/ResiliencePipelineBuilderBase.cs Outdated Show resolved Hide resolved
src/Polly.Core/ResiliencePipelineBuilderBase.cs Outdated Show resolved Hide resolved
@cmeyertons cmeyertons mentioned this pull request Oct 16, 2023
4 tasks
@cmeyertons cmeyertons force-pushed the feature/resilience-pool-settable branch from e64f532 to a4899d7 Compare October 16, 2023 19:09
@cmeyertons
Copy link
Contributor Author

@martincostello @martintmk changes should be good to go from my end -- rebased off main and undid the var extraneous changes.

@martintmk martintmk enabled auto-merge (squash) October 17, 2023 06:19
@martintmk martintmk merged commit a3ca9d0 into App-vNext:main Oct 17, 2023
18 checks passed
@martincostello martincostello added this to the v8.1.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants