-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1687 - Make ResilienceContextPool settable via DI #1693
#1687 - Make ResilienceContextPool settable via DI #1693
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.02%
==========================================
Files 306 306
Lines 6819 6829 +10
Branches 1045 1046 +1
==========================================
+ Hits 5771 5781 +10
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me, but I'll leave the other Martin to give a 👍 or 👎
test/Polly.Core.Tests/Utils/Pipeline/CompositePipelineComponentTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
e64f532
to
a4899d7
Compare
@martincostello @martintmk changes should be good to go from my end -- rebased off |
Pull Request
The issue or feature being addressed
#1687
Details on the issue fix or feature implementation
Followed @martintmk suggestion to make
ResilientContextPool
settable via DI pipelineConfirm the following