Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add diagram to action generator hedging #1713

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

  • Add sequence diagrams to the documentation to ease the understanding of the strategies

Details on the issue fix or feature implementation

  • Replaced InfiniteTimespan to TimeSpan.FromSeconds(-1)
  • Fixed inconsistencies between diagrams
  • Fixed Parallel: unhappy path sequence diagram section's description
  • Added description to complex circuit breaker scenarios
  • Added Action generator: sequence diagram section

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (345e6bf) 84.65% compared to head (ed8d764) 84.65%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         306      306           
  Lines        6831     6831           
  Branches     1047     1047           
=======================================
  Hits         5783     5783           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.65% <ø> (ø)
windows 84.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/fallback.md Outdated Show resolved Hide resolved
docs/strategies/hedging.md Outdated Show resolved Hide resolved
@peter-csala peter-csala changed the title Add diagram to action generator hedging [Docs] Add diagram to action generator hedging Oct 20, 2023
@martincostello martincostello enabled auto-merge (squash) October 20, 2023 14:14
@martincostello martincostello merged commit 86b4e29 into App-vNext:main Oct 20, 2023
14 checks passed
@peter-csala peter-csala deleted the add-diagrams-part-5 branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants