Fix PipelineNameComparer example in documentation #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses App-vNext#1926 In the Complex Pipeline Keys documenation example: https://www.pollydocs.org/advanced/dependency-injection.html#complex-pipeline-keys PipelineNameComparer.GetHashCode takes the InstanceName into account, but shouldn't. This fixes that line in the documentation.
Addresses App-vNext#1926 In the Complex Pipeline Keys documenation example: https://www.pollydocs.org/advanced/dependency-injection.html#complex-pipeline-keys PipelineNameComparer.GetHashCode takes the InstanceName into account, but shouldn't. This fixes that line in the documentation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
+ Coverage 84.79% 84.81% +0.01%
==========================================
Files 312 312
Lines 6893 6901 +8
Branches 1056 1056
==========================================
+ Hits 5845 5853 +8
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1926
Details on the issue fix or feature implementation
In the Complex Pipeline Keys documentation example:
https://www.pollydocs.org/advanced/dependency-injection.html#complex-pipeline-keys
PipelineNameComparer.GetHashCode takes the InstanceName into account, but shouldn't. This fixes that line in the documentation and snippet.
Confirm the following