-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache default(TResult) values #559
Conversation
Please review carefully, these are non-trivial changes to both code and tests. Also, feel free to merge and make changes yourself if that's quicker/easier than having me update the PR. |
Thanks @cmeeren . PR looks great! I am going to push four more tests which prove the Individual cache providers may of course impose their own limitations on caching Note: I am holding (not merging) this PR until we have ready the associated fixes to Polly cache providers and serialization providers:
But otherwise I think this PR (with extra tests I'll push) is good to go. |
@cmeeren I'm merging this into the v7.0.0 dev branch now, as I've brought the cache providers and serializers into alignment with the v7.0 changes, in the following PRs:
Please feel free to review those PRs. Each cache provider repo now has integration tests proving we can round-trip cache or serialize a range of values across a range of types, including the Thanks for your contribution! You have credit in the readme! |
Thanks, happy to help! :) |
Fixes #523
Details on the issue fix or feature implementation
I have not added any new unit tests, because I think it's adequately covered by the numerous adapted tests.
Confirm the following