Skip to content

Conversation

zacharee
Copy link

This PR converts all Java source files to Kotlin. The initial pass was done with Android Studio's automatic converter with manual changes made afterwards to fix errors and improve nullability indicators. Some code paths were also changed to better work with Kotlin.

I did some testing, but I'm sure there are bugs or unintended behavior changes I missed, so I'm marking this as work-in-progress and hoping to have others help test it.

The new codebase is also not API-compatible with the old version. Some of the changes can be tweaked so generated Java setter names match what they used to be, but Kotlin consumers will have to change to property access syntax, and the way Kotlin's generics work required adding more generic types to some classes.

@hannesa2
Copy link
Collaborator

As pull requests from a fork doesn't run screenshot compare tests, I'll make a pull request with given changes on upstream

@hannesa2 hannesa2 mentioned this pull request Sep 14, 2025
@hannesa2
Copy link
Collaborator

Please see #414

@zacharee
Copy link
Author

I fixed the unit tests and ported in the divide by 0 fix.

@zacharee
Copy link
Author

Brought it back down to Java 17. There was some clashing with defaults that made me set it to 21, but 17 seems to work locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants