Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove flutter overlay #358

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Aug 5, 2023

Tested and couldn't find any issues

@Xazin Xazin requested a review from LucasXu0 August 5, 2023 15:16
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #358 (c3319ba) into main (72d6c52) will decrease coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   80.59%   80.44%   -0.15%     
==========================================
  Files         255      270      +15     
  Lines       10452    11037     +585     
==========================================
+ Hits         8424     8879     +455     
- Misses       2028     2158     +130     
Files Changed Coverage Δ
...ib/src/editor/editor_component/service/editor.dart 92.85% <ø> (ø)
...ditor/editor_component/service/editor_service.dart 100.00% <ø> (ø)
...nt/service/selection/mobile_selection_service.dart 14.34% <0.00%> (+0.05%) ⬆️
...or/editor_component/service/selection_service.dart 100.00% <ø> (ø)
...or_component/service/selection_service_widget.dart 71.05% <ø> (+5.26%) ⬆️
lib/src/flutter/scrollable_helpers.dart 27.12% <ø> (ø)
lib/src/render/toolbar/toolbar_item.dart 82.60% <ø> (ø)
...t/service/selection/desktop_selection_service.dart 86.30% <100.00%> (+4.09%) ⬆️
...b/src/editor/toolbar/desktop/floating_toolbar.dart 74.74% <100.00%> (+0.25%) ⬆️

... and 34 files with indirect coverage changes

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Aug 8, 2023

x.mp4

@Xazin found a new issue.

@Xazin
Copy link
Collaborator Author

Xazin commented Aug 17, 2023

x.mp4
@Xazin found a new issue.

This happens to me even with the old version of the overlay.dart.

@LucasXu0
Copy link
Collaborator

Hide the toolbar when the selection is invisible.

https://www.loom.com/share/723d73bdd289455e8b88fdc1f7ce5604

@LucasXu0 LucasXu0 merged commit 81fbb40 into AppFlowy-IO:main Aug 29, 2023
9 of 11 checks passed
LucasXu0 added a commit to LucasXu0/appflowy-editor that referenced this pull request Aug 29, 2023
LucasXu0 added a commit that referenced this pull request Aug 29, 2023
* Revert "fix: remove flutter overlay (#358)"

This reverts commit 81fbb40.

* fix: hide toolbar when the selection area is invisible
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 5, 2023
* main:
  feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437)
  chore: bump version 1.3.0 (AppFlowy-IO#435)
  fix: better column resize performance (AppFlowy-IO#434)
  fix: table padding and selection (AppFlowy-IO#432)
  fix: table block bugs (AppFlowy-IO#431)
  fix: refactor text alignment handling in block components
  Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427)
  feat: support alignment for block component (AppFlowy-IO#425)
  fix: remove flutter overlay (AppFlowy-IO#358)
  feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333)
  feat: table plugin (AppFlowy-IO#62)
  feat: editor state update node (AppFlowy-IO#405)
  fix: exception on prev node text direction null (AppFlowy-IO#404)
  fix: html encoder not adding multiple text decorations (AppFlowy-IO#424)
  feat: default text direction property (AppFlowy-IO#402)
  fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371)
  chore: update theme colors for editor
  feat: refactor floating toolbar positioning logic
  fix: update resizable image width calculation with minimum width constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants