Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: remove flutter overlay (#358)" #427

Conversation

LucasXu0
Copy link
Collaborator

This reverts commit 81fbb40.

@LucasXu0
Copy link
Collaborator Author

before

Screenshot 2023-08-29 at 17 05 51

after

Screenshot 2023-08-29 at 17 04 59

This commit affects the position of the selection menu. Revert it temporarily.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #427 (9e110bd) into main (836e4cb) will decrease coverage by 0.72%.
The diff coverage is 57.61%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   80.39%   79.67%   -0.72%     
==========================================
  Files         272      273       +1     
  Lines       11067    11395     +328     
==========================================
+ Hits         8897     9079     +182     
- Misses       2170     2316     +146     
Files Changed Coverage Δ
...ib/src/editor/editor_component/service/editor.dart 92.85% <ø> (ø)
...ditor/editor_component/service/editor_service.dart 100.00% <ø> (ø)
...nt/service/selection/mobile_selection_service.dart 14.28% <0.00%> (-0.06%) ⬇️
...or/editor_component/service/selection_service.dart 100.00% <ø> (ø)
...or_component/service/selection_service_widget.dart 71.05% <ø> (ø)
lib/src/flutter/scrollable_helpers.dart 27.12% <ø> (ø)
lib/src/render/toolbar/toolbar_item.dart 82.60% <ø> (ø)
lib/src/flutter/overlay.dart 57.79% <57.79%> (ø)
...t/service/selection/desktop_selection_service.dart 86.30% <100.00%> (ø)

... and 5 files with indirect coverage changes

@LucasXu0 LucasXu0 merged commit e59b361 into AppFlowy-IO:main Aug 29, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 5, 2023
* main:
  feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437)
  chore: bump version 1.3.0 (AppFlowy-IO#435)
  fix: better column resize performance (AppFlowy-IO#434)
  fix: table padding and selection (AppFlowy-IO#432)
  fix: table block bugs (AppFlowy-IO#431)
  fix: refactor text alignment handling in block components
  Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427)
  feat: support alignment for block component (AppFlowy-IO#425)
  fix: remove flutter overlay (AppFlowy-IO#358)
  feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333)
  feat: table plugin (AppFlowy-IO#62)
  feat: editor state update node (AppFlowy-IO#405)
  fix: exception on prev node text direction null (AppFlowy-IO#404)
  fix: html encoder not adding multiple text decorations (AppFlowy-IO#424)
  feat: default text direction property (AppFlowy-IO#402)
  fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371)
  chore: update theme colors for editor
  feat: refactor floating toolbar positioning logic
  fix: update resizable image width calculation with minimum width constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant