fix: table block bugs #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LucasXu0
commented
Aug 30, 2023
LucasXu0
commented
- send transaction after resizing the table
- apply selection after inserting the table
- fix some tests
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 79.72% 79.95% +0.22%
==========================================
Files 274 274
Lines 11406 11457 +51
==========================================
+ Hits 9093 9160 +67
+ Misses 2313 2297 -16
☔ View full report in Codecov by Sentry. |
pass only transaction to methods directly.
With current transaction adapter in Appflowy which creates `BlockActionPB` for `documentService` (backend). Its not possible to have multiple `InsertOperation`s separately as a single transaction (multiple `transaction.insertNode()`). The `BlockActionPB` creator (`toBlockAction`) can't figure out the `prevId` (previous node of inserting node id), The first insert operations shifts all next nodes path. Because of this situation we decided to apply the insert operations one by one.
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Sep 5, 2023
* main: feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437) chore: bump version 1.3.0 (AppFlowy-IO#435) fix: better column resize performance (AppFlowy-IO#434) fix: table padding and selection (AppFlowy-IO#432) fix: table block bugs (AppFlowy-IO#431) fix: refactor text alignment handling in block components Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427) feat: support alignment for block component (AppFlowy-IO#425) fix: remove flutter overlay (AppFlowy-IO#358) feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333) feat: table plugin (AppFlowy-IO#62) feat: editor state update node (AppFlowy-IO#405) fix: exception on prev node text direction null (AppFlowy-IO#404) fix: html encoder not adding multiple text decorations (AppFlowy-IO#424) feat: default text direction property (AppFlowy-IO#402) fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371) chore: update theme colors for editor feat: refactor floating toolbar positioning logic fix: update resizable image width calculation with minimum width constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.