feat: table plugin #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rust backend (flowy-document) doesn't support it.
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
Xazin
reviewed
Apr 13, 2023
|
Implemented markdown decode/encode feature for table. |
* main: feat: support uploading images from local files (AppFlowy-IO#232) fix: desktop tooltips incorrect (AppFlowy-IO#259) fix: add underline syntax parser (AppFlowy-IO#256) chore: add reload function into editor state fix: ignore the same value update in input service (AppFlowy-IO#257) Revert "feat: support mobile IME (AppFlowy-IO#255)" feat: support item count filter in selection menu results (AppFlowy-IO#254) feat: support mobile IME (AppFlowy-IO#255) feat: replace DeltaTextInputClient with TextInputClient (AppFlowy-IO#253)
|
@zoli Is it ready to review and merge? |
Yes. The design and maybe some UX corners could improve, But I think enhancing them incrementally is better. |
|
I can't wait to try this. When will this feature be released? |
In my last discussion with @LucasXu0, he said we should move the plugin to Appflowy repo. |
LucasXu0
force-pushed
the
feat/table-plugin
branch
from
cf94943
to
5406f30
Compare
* main: fix: refactor _onSelectionChange method to update _showPlaceholder state more efficiently fix: typo (AppFlowy-IO#408) Fix selected nodes (AppFlowy-IO#407) fix: miss the nested node when copying (AppFlowy-IO#406)
* main: chore: comment suggesting use of deprecated method (AppFlowy-IO#417) fix: replace matches on the same node (AppFlowy-IO#418)
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Sep 5, 2023
* main: feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437) chore: bump version 1.3.0 (AppFlowy-IO#435) fix: better column resize performance (AppFlowy-IO#434) fix: table padding and selection (AppFlowy-IO#432) fix: table block bugs (AppFlowy-IO#431) fix: refactor text alignment handling in block components Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427) feat: support alignment for block component (AppFlowy-IO#425) fix: remove flutter overlay (AppFlowy-IO#358) feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333) feat: table plugin (AppFlowy-IO#62) feat: editor state update node (AppFlowy-IO#405) fix: exception on prev node text direction null (AppFlowy-IO#404) fix: html encoder not adding multiple text decorations (AppFlowy-IO#424) feat: default text direction property (AppFlowy-IO#402) fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371) chore: update theme colors for editor feat: refactor floating toolbar positioning logic fix: update resizable image width calculation with minimum width constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from AppFlowy-IO/AppFlowy#2120.
Nodetypes 'table' and 'table/cell'. The 'table/cell' node for now contains singleTextNode. All the data is kept in node attributes. Data related to 'table' like number of rows and columns are in 'table' node attributes and data related to each table cell is in 'table/cell' node attribute (cell height, position of cell its row and column). TheTextNodein table cell supports selection menu and toolbar but not all of them work inside the table cell (some of them are not applicable in table cell).isApplicabletoContextMenuItemso we can have context-base context menubackspaceEventHandlerso it won't move from one table cell to another cell and also handling backspace when the selection includes part of table cells and none table related nodes._getNodeInOffsetso selection also works when we have multiple nodes in a single line (same y position). I will add more info on this in another comment.ColorPickermore customizable and reusable for other than toolbar service.