Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better column resize performance #434

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

zoli
Copy link
Contributor

@zoli zoli commented Aug 31, 2023

This should get merged after #432.

The handler was getting out of region when table width was wider
than editor size.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 52.94% and project coverage change: -0.02% ⚠️

Comparison is base (f205f80) 79.95% compared to head (006b926) 79.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   79.95%   79.93%   -0.02%     
==========================================
  Files         274      274              
  Lines       11457    11463       +6     
==========================================
+ Hits         9160     9163       +3     
- Misses       2297     2300       +3     
Files Changed Coverage Δ
...t/table_block_component/table_block_component.dart 58.94% <ø> (ø)
...le_block_component/table_cell_block_component.dart 92.30% <ø> (-0.15%) ⬇️
...ponent/table_block_component/table_col_border.dart 53.84% <0.00%> (+2.62%) ⬆️
...ck_component/table_block_component/table_node.dart 93.13% <66.66%> (-4.81%) ⬇️
...ock_component/table_block_component/table_col.dart 96.96% <100.00%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit b429ae6 into AppFlowy-IO:main Sep 1, 2023
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 5, 2023
* main:
  feat: simplify auto scroll behavior in ScrollServiceWidget (AppFlowy-IO#437)
  chore: bump version 1.3.0 (AppFlowy-IO#435)
  fix: better column resize performance (AppFlowy-IO#434)
  fix: table padding and selection (AppFlowy-IO#432)
  fix: table block bugs (AppFlowy-IO#431)
  fix: refactor text alignment handling in block components
  Revert "fix: remove flutter overlay (AppFlowy-IO#358)" (AppFlowy-IO#427)
  feat: support alignment for block component (AppFlowy-IO#425)
  fix: remove flutter overlay (AppFlowy-IO#358)
  feat: toggle highlight using ctrl/cmd + shift + h (AppFlowy-IO#333)
  feat: table plugin (AppFlowy-IO#62)
  feat: editor state update node (AppFlowy-IO#405)
  fix: exception on prev node text direction null (AppFlowy-IO#404)
  fix: html encoder not adding multiple text decorations (AppFlowy-IO#424)
  feat: default text direction property (AppFlowy-IO#402)
  fix: fixed the cursor not moving to next line after inserting divider (AppFlowy-IO#371)
  chore: update theme colors for editor
  feat: refactor floating toolbar positioning logic
  fix: update resizable image width calculation with minimum width constraint
@zoli zoli deleted the fix/table-column-resize-perf branch September 18, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants