Skip to content

Conversation

sinatragianpaolo
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 8, 2025

Tests difference:

New Tests

< Errors - Should answer 400 if campaign does not exists

Removed Tests

> Errors - Should answer 404 if campaign does not exists

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 77.863% (-0.07%) from 77.928%
when pulling f5e47d0 on quote-routes-fix-permissions
into febf7a1 on develop.

@d-beezee d-beezee requested a review from Copilot April 8, 2025 13:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/routes/dossiers/campaignId/quotations/quoteId/_patch/index.ts:15

  • [nitpick] The 'accessibleCampaigns' variable uses a union type (true | number[]) to denote full or limited access. Consider adding a clarifying comment or renaming the variable to clearly indicate its dual purpose.
private accessibleCampaigns: true | number[] = this.campaignOlps ? this.campaignOlps : [];

src/routes/dossiers/campaignId/quotations/quoteId/_patch/index.ts:43

  • The explicit campaign existence check was removed. Verify that campaign validity is appropriately handled by CampaignRoute or elsewhere so that non-existent campaigns trigger the correct error response.
if (await this.campaignNotExist()) {

@cannarocks cannarocks merged commit ae859a9 into develop Apr 8, 2025
5 of 7 checks passed
@cannarocks cannarocks deleted the quote-routes-fix-permissions branch April 8, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants