-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of AppManager #99
Conversation
bumped version number to 1.6.3
bumped version number to 1.6.3
…h how the AppController sends them over, fixing issue AppScale#18
…xactly we get back from ifconfig to parse our IP from
… address in zookeeper, instead of trying to remove the whole directory
…a-fix IaaS Manager Sources credentials properly
…ppcontroller-fix Remove app via appcontroller fix
Local IP caching
…tore, also refactored datastore and users code
…'t always resolve constant values in the code and will just hardcode them, it's too tedious to go through and replace all of these so I just did the major ones
Java server sdk updates
Removed sisyphus from code base
Removed sisyphus from code base
Terminate AppServer when process is over soft memory cap
flexmock(appscale_info).should_receive('get_secret')\ | ||
.and_return(fake_secret) | ||
cmd = app_manager_server.create_python_stop_cmd(port) | ||
assert port in cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use self.assertEquals
, which is the proper way to use Python unittest.
I've created an issue for this On Fri, Nov 16, 2012 at 9:36 AM, Chris Bunch notifications@github.comwrote:
Navraj Chohan (Raj) |
fixed. Was missing a mock. Will test on a local checkout to verify. On Fri, Nov 16, 2012 at 9:38 AM, Chris Bunch notifications@github.comwrote:
Navraj Chohan (Raj) |
Looks great now. Can you do a merge with |
Migrating the starting and stopping of applications out of the AppController to a new Python service, named the AppManager.