Terminate AppServer when process is over soft memory cap#82
Merged
shatterednirvana merged 3 commits intoAppScale:testingfrom Nov 13, 2012
Merged
Terminate AppServer when process is over soft memory cap#82shatterednirvana merged 3 commits intoAppScale:testingfrom
shatterednirvana merged 3 commits intoAppScale:testingfrom
Conversation
bumped version number to 1.6.3
Contributor
There was a problem hiding this comment.
I don't understand this comment. Should this instead be something like "The probability that we should terminate an AppServer that has exceeded its memory limit"?
ghost
assigned
shatterednirvana
added a commit
that referenced
this pull request
Nov 13, 2012
Terminate AppServer when process is over soft memory cap
Contributor
Author
|
@shatterednirvana To test this set the SOFT_CAP_MEM to a lower number like 55000. Upload guestbook with --appengine 20 and run ab tool against it. |
Contributor
|
Why should I lower the |
Contributor
|
This doesn't work for me - I get an ImportError on the random class. Working on a fix now. |
nlake44
added a commit
to nlake44/appscale
that referenced
this pull request
Sep 30, 2013
Add 'ssh' command to 'appscale'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Python AppServer in AppScale (adapted from the SDK Google gives out) leaks memory. To reproduce this, run the guestbook application and post to it. From this point on, even if a user only performs read operations, the AppServer will leak memory.
This pull request terminates the Python AppServer if it uses more memory than a preset threshold. Investigation using the objgraph python library shows that there is a dictionary growing by 2 (could also be two dictionaries growing 1 each) and a list growing by 1. Which list and which dictionary requires further investigation.