Java upgrade and api pathwise metrics #16
Conversation
…ath to show data per api endpoint
…t in the cloudwatch apigateway namespace
cold-magma
changed the title
cold-magma
force-pushed
the
feature/java_upgrade_and_api_pathwise_metrics
branch
from
e9809f0 to
2518c55
Compare
|
|
||
| DimensionFilter apiNameDimensionFilter = new DimensionFilter(); | ||
| apiNameDimensionFilter.withName(APINAME); | ||
| DimensionFilter apiNameDimensionFilter = DimensionFilter.builder() |
There was a problem hiding this comment.
instead of APIName, why 3 diff dimention filters were created?
There was a problem hiding this comment.
ApiName is not a filter in cloudwatch. they changed the schema to ApiId,Stage and Resource
| for(Dimension dimension : metric.getDimensions()) { | ||
| if(dimension.getName().equalsIgnoreCase("ApiName")) { | ||
| apiName = dimension.getValue(); | ||
| for(Dimension dimension : metric.dimensions()) { |
src/main/resources/conf/config.yml
Outdated
| awsSecretKey: "" | ||
| displayAccountName: "AppD" | ||
| regions: ["us-west-2"] | ||
| displayAccountName: "Test Gateway" |
There was a problem hiding this comment.
is this display account name is correct?
There was a problem hiding this comment.
This is just a placeholder. it is customised by customer based on their needs.
There was a problem hiding this comment.
Even as a place holder, please do restore the previous displayName
src/main/resources/conf/config.yml
Outdated
| # Global time range configuration, applicable to all the metrics configured below. | ||
| metricsTimeRange: | ||
| startTimeInMinsBeforeNow: 10 | ||
| startTimeInMinsBeforeNow: 60 |
There was a problem hiding this comment.
what is the purpose of increasing the starttime by 60 min?
There was a problem hiding this comment.
This is just a placeholder. it is customised by customer based on their metrics size.
There was a problem hiding this comment.
in that case, please dont change the value so that it does not create any confusion unnecessary
Upgraded java version to 17
Upgraded aws-cloudwatch-exts-commons to 2.2.8
Added stage and resource to the metric path on collect by adding additional dimensions