Initial commit #1
Conversation
Signed-off-by: Satvik Shubham Singh <58393226+satvikshubham@users.noreply.github.com>
| **** | ||
| For using bhlib in your app, add the below dependency in the entry/package.json | ||
| ``` | ||
| "dependencies": { |
There was a problem hiding this comment.
add dependency command like this
npm i @ohos/bhlib
| */ | ||
|
|
||
| export class Business { | ||
| private workingDays: boolean[] = [false, false, false, false, false, false, false]; |
There was a problem hiding this comment.
add properties in custom component using model class
|
|
||
| @CustomDialog | ||
| export struct TimeSelectorDialog { | ||
| time: string |
There was a problem hiding this comment.
add properties in custom component using model class
|
|
||
| @Component | ||
| export struct BusinessHoursWeekView { | ||
| private showBusinessModel: Business = undefined |
There was a problem hiding this comment.
add properties in custom component using model class
| dayInd: number | ||
| format: number | ||
| callback: (selIndex, where, dayInd) => void | ||
| arr12: string [] = [ |
There was a problem hiding this comment.
add these arr12 & arr24 variables in separate constant file
| @CustomDialog | ||
| export struct TimeSelectorDialog { | ||
| time: string | ||
| where: string |
There was a problem hiding this comment.
time, where, dayInd, format
add these properties in model class
| .textAlign(TextAlign.Center) | ||
| .backgroundColor(0xFFFFFF) | ||
| .onClick(() => { | ||
| this.callback(item, this.where, this.dayInd) |
There was a problem hiding this comment.
handle null & undefined validations on callback variable
| .textAlign(TextAlign.Center) | ||
| .backgroundColor(0xFFFFFF) | ||
| .onClick(() => { | ||
| this.callback(item, this.where, this.dayInd) |
There was a problem hiding this comment.
handle null & undefined validations on callback variable
| } | ||
| } | ||
|
|
||
| bhTextColor: string = '#000000' |
There was a problem hiding this comment.
create a model class for BusinessDayAndTime component and add all variables from this component in model class
| @Component | ||
| export struct BusinessHoursWeekView { | ||
| private showBusinessModel: BusinessModel = undefined | ||
| isToday = new Date().getDay() |
There was a problem hiding this comment.
create a model class for BusinessHoursWeekView component and add all variables from this component in model class
| } | ||
|
|
||
| setWorkingDay = (day: number, v: boolean): void => { | ||
| this.workingDays[day - 1] = v; |
There was a problem hiding this comment.
handle null & undefined validations before assigning values to a variable in all setter methods
| export struct BusinessPicker { | ||
| @Link selectedBusinessModel: BusinessModel | ||
| day: string [] = BusinessModel.dayArr | ||
| arr: number[] = [0, 1, 2, 3, 4, 5, 6] |
There was a problem hiding this comment.
create a model class for BusinessPicker component and add all variables from this component in model class
| @@ -0,0 +1,8 @@ | |||
| export default { | |||
|
Add Copyright text in all ts/ets files |
| ForEach(this.arr24, (item) => { | ||
| ListItem() { | ||
| Text(item) | ||
| .fontSize(16) |
There was a problem hiding this comment.
Mark all fontsizes as fp and dimentions as vp, recheck in all files and handle.
package.json
Outdated
| "hypium": "^1.0.0", | ||
| "@ohos/hvigor": "1.0.6", | ||
| "@ohos/hvigor-ohos-plugin": "1.0.6", | ||
| "@ohos/bhlib": "file:./bhlib" |
There was a problem hiding this comment.
remove the bhlib dependency from here and add at entry's package.json
Signed-off-by: Satvik Shubham Singh 58393226+satvikshubham@users.noreply.github.com