Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global onkey listeners interfering with normal use #41

Closed
ascherer1993 opened this issue Nov 8, 2018 · 2 comments
Closed

Global onkey listeners interfering with normal use #41

ascherer1993 opened this issue Nov 8, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@ascherer1993
Copy link

Key listeners are causing problems when using other parts of the application.

Example/How to reproduce

  1. Create an annotation
  2. Open the notes panel
  3. Create several comments on the annotation
  4. Try to copy text from another comment using ctrl + C and try to paste it into the reply text area with ctrl + V. You should notice that you have ended up creating a copy of the annotation that was selected.

We noticed this when implementing a custom modal and these actions were being performed behind our modal. If there is a way to avoid these issues that would be helpful.

@justinjung04
Copy link
Contributor

We reproduced the issue. We'll come up with a fix soon!

@justinjung04 justinjung04 added the bug Something isn't working label Nov 9, 2018
@henry-chris
Copy link

@justinjung04 Please note that it's not just ctrl C. It's all hotkeys. Delete, ctrl+v, backspace, etc... And for prettymuch all context menus/modals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants