Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme & design #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

sampoearas
Copy link

  • Updated readme layout
  • Updated Install Steps with IOM install
  • Updated design of webpage (colors, font, text placeholders)
  • Updated screenshot with new design
  • Tested project on Aras v11.12-15, v12.0

- Updated readme layout
- Updated Install Steps with IOM install
- Updated design of webpage
- Updated screenshot with new design
- Tested project on Aras v12.0
@sampoearas sampoearas added the Status: Needs Review Needs to be reviewed. label Jun 27, 2019
Copy link
Member

@EliJDonahue EliJDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of new files added that aren't needed and shouldn't be included in the repository, like the sqlite3 folder, .vs folder, all of the dlls in the bin folder, and everything in the obj folder. Look up a .gitignore template for this type of Visual Studio project, add it to your local repo, and ignore/untrack these files.

README.md Outdated
6. Once the connection is made and the new PR is created with the data provided by the user, a confirmation window will appear.

![Customized Dashboard](./Screenshots/PR%20Web%20Page%20Filled%20In.PNG)
*The PR Web Page with log in credentials and PR data filled out*
![Customized Dashboard](./Screenshots/PR-WebPage2.PNG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url doesn't work. GitHub is case-sensitive, and the actual file name has a lower case file extension.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed extension

README.md Outdated

## Usage

1. Open the solution in Visual Studio.
2. Start the External_Input_Example project.
3. Wait for the the web page to load
1. Select the browser you want to run it in.
3. Wait for the the web page to load.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated "the". Please fix.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed grammar.

Revert ".gitignore is now working"

This reverts commit f0fc00081cabff191de9ab573fa15a1bd851f52d.

Update .gitignore file

- bypass Aras DLLs
Apply .gitignore prefs

Revert "Apply .gitignore prefs"

This reverts commit e8621e60fb0b13e8087ee3225ed3d89b844d5b5b.

Update gitignore


Apply .gitignore prefs

Revert "Apply .gitignore prefs"

This reverts commit 457f5341e94b2082dc3ddce304ac5bb20e647f15.

update gitignore


Apply .gitignore prefs

update gitignore


Apply .gitignore prefs

update gitignore


Apply .gitignore prefs
@sampoearas
Copy link
Author

Changes made. gitignore added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants