Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor HTTP API server command handler #1236

Merged
merged 1 commit into from
Sep 10, 2023
Merged

refactor HTTP API server command handler #1236

merged 1 commit into from
Sep 10, 2023

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Sep 10, 2023

What does this PR do?

These changes improve the way server commands are handled in particular:

  • server commands are now case insensitive
  • Not the commands but their payload is passed to the private function executing the server command
  • Server commands are defined as strings to be DRY
  • Order of commands and their execution methods is consistent now
  • Special case of "list databases" is handled first, slightly reducing complexity

Motivation

What inspired you to submit this pull request?

Related issues

#1235

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios (remains to be done)

@lvca
Copy link
Contributor

lvca commented Sep 10, 2023

Big cleanup, thanks!!!

@lvca lvca merged commit 753d799 into ArcadeData:main Sep 10, 2023
5 of 7 checks passed
@lvca lvca added the enhancement New feature or request label Sep 10, 2023
@lvca lvca added this to the 23.9.1 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gramian gramian

Labels
enhancement New feature or request
Projects
None yet
Milestone
23.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gramian @lvca