#1279 add full and minimal packages #1280

robfrank · 2023-10-18T22:38:11Z

Related issues

When merged, the package project will produce three different zip/tar.gz and three different Docker images:

arcadedb-package-VERSIOM.zip: as before, the full fledge package with all the plugin inside
arcadedb-minimal-VERSION.zip
arcadedb-headless-VERSION.zip

What is removed in mininal and headless (as per related issue #1279) :

minimal:

            <excludes>
                <exclude>com.arcadedb:arcadedb-gremlin</exclude>
                <exclude>com.arcadedb:arcadedb-redisw</exclude>
                <exclude>com.arcadedb:arcadedb-mongodbw</exclude>
                <exclude>com.arcadedb:arcadedb-graphql</exclude>
            </excludes>

headless:

            <excludes>
                <exclude>com.arcadedb:arcadedb-gremlin</exclude>
                <exclude>com.arcadedb:arcadedb-redisw</exclude>
                <exclude>com.arcadedb:arcadedb-mongodbw</exclude>
                <exclude>com.arcadedb:arcadedb-graphql</exclude>
                <exclude>com.arcadedb:arcadedb-studio</exclude>
            </excludes>

Docker images will be:

arcadedata/arcadedb: as before, the full version (non rename)
arcadedata/arcadedb-minimal
arcadedata/arcadedb-headless

In this case, I kept the same name to don't force people that is using the Docker image in docker-compose, scripts, k8s to rename the reference to the image in a lot of files

Again, @lvca , WDYT?

Additionale notes

the "code" relative to Studio is in its own module
pre-commit is configure to format js and xml

lvca · 2023-11-26T14:55:46Z

Thanks @robfrank , this is huge! What is in and out the 2 new distribution?

robfrank · 2023-11-26T17:07:09Z

@lvca note that I moved all the js/html files in a dedicated module, that's why we have so many files in the PR

lvca

I love you separated studio!

lvca · 2023-11-26T18:09:06Z

gremlin/src/test/resources/gremlin-server.yaml

@@ -9,7 +9,7 @@ scriptEngines:
        classImports:
          - java.lang.Math
        methodImports:
-          - 'java.lang.Math#*'


Was this intentional or some IDE auto formatting?

autoformatter

lvca · 2023-11-26T18:10:15Z

package/pom.xml

                        <phase>package</phase>
                        <goals>
                            <goal>single</goal>
                        </goals>
                        <configuration>
                            <appendAssemblyId>false</appendAssemblyId>
-                            <finalName>arcadedb-${project.version}</finalName>
+                            <finalName>arcadedb-package-${project.version}</finalName>


What about using arcadedb-full as a name? So everybody understand it's the full version?

was my first choice. But then I preferred to not create problems to people that is referring, maybe in their scripts, to arcadedb-package

I think it's the opposite: now arcadedb-package is just a sub-project to pack up the distribution and everybody is using just "arcadedb-".

no, it's deployed on maven central: https://repo.maven.apache.org/maven2/com/arcadedb/arcadedb-package/23.9.1/

I never noticed we published the whole distribution on Maven, not only GitHub! But nobody is linking that package because it's a zip. not a jar. So we can even get rid of that and nobody would notice. The zip file is directly available on github.

The only doubt is about the name of the full distribution. In Docker we keep the current name (no suffix), that doesn't break compatibility 👍 But for the release we change it to "package" just to stick with the current zip deployed on maven, but nobody I think ever used it.

What if we remove the suffix from it? So we'd have (I usually upload the .tar.gz instead of .zip on github because it keeps the UNIX permissions on the .sh files):

arcadedb-VERSION.tar.gz: as before, the full-fledged package with all the plugins inside

arcadedb-minimal-VERSION.tar.gz

arcadedb-headless-VERSION.tar.gz

And same for docker:

arcadedata/arcadedb: as before, the full version (non rename)

arcadedata/arcadedb-minimal

arcadedata/arcadedb-headless

Ok, this commit 4421646

does that

lvca · 2023-11-26T18:11:14Z

package/src/main/assembly/minimal.xml

+                <include>*:jar:*</include>
+            </includes>
+            <excludes>
+                <exclude>com.arcadedb:arcadedb-gremlin</exclude>


If you exclude gremlin, does it automatically exclude al the linked jars?

yes because every pplugin (gremlin, redis, postgres) is packaged as a single fat jar (note the size):

22K Nov 26 21:17 arcadedb-console-23.11.1-SNAPSHOT.jar 2.0M Nov 26 21:17 arcadedb-engine-23.11.1-SNAPSHOT.jar 101K Nov 26 21:17 arcadedb-graphql-23.11.1-SNAPSHOT.jar 43M Nov 26 21:17 arcadedb-gremlin-23.11.1-SNAPSHOT.jar 166K Nov 26 21:17 arcadedb-integration-23.11.1-SNAPSHOT.jar 2.8M Nov 26 21:17 arcadedb-mongodbw-23.11.1-SNAPSHOT.jar 74K Nov 26 21:17 arcadedb-network-23.11.1-SNAPSHOT.jar 32K Nov 26 21:17 arcadedb-postgresw-23.11.1-SNAPSHOT.jar 16K Nov 26 21:17 arcadedb-redisw-23.11.1-SNAPSHOT.jar 267K Nov 26 21:17 arcadedb-server-23.11.1-SNAPSHOT.jar .0M Nov 26 21:17 arcadedb-studio-23.11.1-SNAPSHOT.jar

Why studio is empty? console is only 22k? It seems like it's not including depending jars from the console. Or perhaps the fatjar is only with gremlin?

fatjar is oly for plugins: redis, gremlin, postgresql, mongodb.
errata corrige for tudio:

7.0M Nov 26 21:17 arcadedb-studio-23.11.1-SNAPSHOT.jar

lvca · 2023-11-28T22:44:48Z

Approved

robfrank force-pushed the feature-1279/packaging branch 3 times, most recently from 3d9d2de to 9d1b1fb Compare November 1, 2023 15:33

robfrank force-pushed the feature-1279/packaging branch from 9d1b1fb to 3b3282d Compare November 12, 2023 14:49

robfrank force-pushed the feature-1279/packaging branch 2 times, most recently from b3584e3 to 35677d9 Compare November 26, 2023 08:46

robfrank requested a review from lvca November 26, 2023 14:29

robfrank marked this pull request as ready for review November 26, 2023 14:29

lvca requested changes Nov 26, 2023

View reviewed changes

robfrank requested a review from lvca November 28, 2023 08:21

robfrank added 14 commits November 28, 2023 22:02

#1279 add full and minimal packages

8771598

#1279 move web code to dedicated module

9907a38

#1279 rename to arcadedb-web

813ab50

#1279 fix pre-commit

5a6d6f0

#1279 add headless packaging

77c981e

1279 remove Dockerfile-multi

052875e

#1279 add docker build for minimal and headless

8de2311

#1279 fix version of webmodule

aa94202

chore: pre-commit update

2f60d72

chore: pre-commit

268277b

chore: pre-commit conf

c3ce10e

#1279 renamed module web to studio

55d82b2

#1279 fix yaml

690ff1b

#1279 rename full package to package, as before

d7bf5d2

robfrank force-pushed the feature-1279/packaging branch from 10d37c8 to d7bf5d2 Compare November 28, 2023 21:02

#1279 rename arcadedb-package to arcadedb

4421646

arcade-player merged commit 0cee8ae into main Nov 29, 2023
6 of 11 checks passed

lvca added this to the 23.11.1 milestone Nov 29, 2023

lvca added the enhancement New feature or request label Nov 29, 2023

lvca assigned robfrank Nov 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1279 add full and minimal packages #1280

#1279 add full and minimal packages #1280

robfrank commented Oct 18, 2023 •

edited

Loading

lvca commented Nov 26, 2023

robfrank commented Nov 26, 2023

lvca left a comment

lvca Nov 26, 2023

robfrank Nov 26, 2023

lvca Nov 26, 2023

robfrank Nov 26, 2023

lvca Nov 26, 2023

robfrank Nov 26, 2023

lvca Nov 28, 2023

robfrank Nov 28, 2023

lvca Nov 26, 2023

robfrank Nov 26, 2023 •

edited

Loading

lvca Nov 26, 2023

robfrank Nov 26, 2023

lvca commented Nov 28, 2023

#1279 add full and minimal packages #1280

#1279 add full and minimal packages #1280

Conversation

robfrank commented Oct 18, 2023 • edited Loading

Related issues

lvca commented Nov 26, 2023

robfrank commented Nov 26, 2023

lvca left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robfrank Nov 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lvca commented Nov 28, 2023

robfrank commented Oct 18, 2023 •

edited

Loading

robfrank Nov 26, 2023 •

edited

Loading