Fix https://github.com/ArcadeData/arcadedb/issues/97

[LLuke]

What does this PR do?

Both console.bat and serer.bat don't take command line argument well due to two similar defects.

Motivation

Share the fixes so that the windows users can use arcadedb out of the box in the arcadedb future releases.

Related issues

The @echo off also partially addressed the noisy issue with #1331

Additional Notes

Test:

create a test database at a new location with console and import something

.\arcadedb-23.10.1\bin\console.bat -Darcadedb.server.databaseDirectory=Z:\arcadedb\databases
> create database arcadedb_test

Database 'arcadedb_test' created
{arcadedb_test}> import database https://github.com/ArcadeData/arcadedb-datasets/raw/main/orientdb/OpenBeer.gz
{arcadedb_test}> quit

start the server with the newly created databse

\arcadedb-23.10.1\bin\server.bat -Darcadedb.server.plugins=Postgres:com.arcadedb.postgres.PostgresProtocolPlugin -Darcadedb.postgres.port=3333 -Darcadedb.server.databaseDirectory=Z:\arcadedb\databases
...

2023-11-18 18:29:33.567 INFO  [PostgresNetworkListener] <ArcadeDB_0> Listening for incoming connections on 0.0.0.0:3333 (protocol v.-1)
2023-11-18 18:29:33.567 INFO  [ArcadeDBServer] <ArcadeDB_0> - Postgres plugin started
...

Test and found the database in the web console (-Darcadedb.server.databaseDirectory=... now works) and it is accessible using pg8000 with code example in #399

Checklist

• [X ] I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[LLuke]

This is probably a CI issue on arcadedb side. I ran tests before checking in.

[lvca]

That's great! Thanks for your first contribution @LLuke !

[gramian]

@lvca @LLuke

I tested the current head with these changes (and the jansi dependency). Both, server and console start. The server seems to work fine and the Windows firewall request permissions. However starting the console, I get the following error:

Exception in thread "WindowsStreamPump" java.lang.NoSuchMethodError: 'int org.fusesource.jansi.internal.Kernel32.WaitForSingleObject(long, int)'
        at org.jline.terminal.impl.jansi.win.JansiWinSysTerminal.processConsoleInput(JansiWinSysTerminal.java:210)
        at org.jline.terminal.impl.AbstractWindowsTerminal.pump(AbstractWindowsTerminal.java:464)
        at java.base/java.lang.Thread.run(Thread.java:840)

Furthermore, and importantly, the console does not accept keyboard input, meaning no pressed key results in an input.

I tested on Windows 10 (64bit) with MS OpenJDK17 (17.0.9).

[lvca]

@gnodet any idea why that can happen? Maybe we have some other version of jline linked from Gremlin? Checking...

[lvca]

jline is added only one time and it's the latest:

|  +- org.jline:jline-terminal:jar:3.24.1:compile
[INFO] |  |  \- org.jline:jline-native:jar:3.24.1:compile
[INFO] |  +- org.jline:jline-reader:jar:3.24.1:compile
[INFO] |  \- org.jline:jline-terminal-jansi:jar:3.24.1:compile
[INFO] |     \- org.fusesource.jansi:jansi:jar:2.4.1:compile

So it must be something with the last version of jansi using a native method:

    public static native int WaitForSingleObject(long hHandle, int dwMilliseconds);

[gnodet]

Ok, I'll try to reproduce and investigate.

[lvca]

For now I reverted the inclusion of jansi lib.