Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record serializer #1670

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix record serializer #1670

merged 1 commit into from
Jul 22, 2024

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Jul 22, 2024

What does this PR do?

This changes fixes the record serializer, which before measures the limit against the response which us unset at this point. Now the limit is compared to the result.

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca merged commit df5e8d7 into ArcadeData:main Jul 22, 2024
6 of 7 checks passed
@lvca lvca added the bug Something isn't working label Jul 22, 2024
@lvca lvca added this to the 24.6.1 milestone Jul 22, 2024
@lvca
Copy link
Contributor

lvca commented Jul 22, 2024

Great!

@lvca lvca added the fixed label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants