Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LegendType with game enum change #63

Closed
Archomeda opened this issue Jun 12, 2020 · 0 comments
Closed

Update LegendType with game enum change #63

Archomeda opened this issue Jun 12, 2020 · 0 comments
Labels
Area: Chat links Related to chat links Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working

Comments

@Archomeda
Copy link
Owner

The enum LegendType is hardcoded to start with 13, but the game update of June 9th, 2020 incremented all those values with 1, causing Legend1 to start at 14.

It's currently not actually used by the chat links, even though I had planned it (but probably forgot about them). It's used as an additional input parameter for the API legends endpoint, which uses a string instead. So the enum change isn't that impactful internally in Gw2Sharp, but might be if dependents actually use it.

@Archomeda Archomeda added Type: Bug Something isn't working good first issue Good for newcomers Priority: Low Low priority Duration: Short Less than 2 hours of estimated work Area: Web API v2 Related to the v2 web API Area: Chat links Related to chat links labels Jun 12, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed good first issue Good for newcomers labels Jun 18, 2020
Archomeda added a commit that referenced this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Chat links Related to chat links Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant