Custom Mumble Link reader #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archomeda
added
Type: Feature
|
SonarCloud Quality Gate failed. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for providing a custom Mumble Link reader. By default this is set to what it always was on Windows. For any other operating system, this is set to a reader that just returns
NotSupportedException. The functionality effectively stays the same as before.SupportedOSPlatformAttributehas been removed in certain areas because it can't be included anymore with this construction, instead it's now placed explicitly on the defaultGw2MumbleClientReaderthat's used on Windows.A bunch of structs have been publicized because they are necessary for the Mumble Link reader interface.