Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some skills appear to have no icon returned by the API.
For example: https://api.guildwars2.com/v2/skills?ids=52116
When the Skill Icon property isn't nullable, checking if it's
!= ""
will throw a NRE because the implicit cast to a string attempts to access the Url property which is null because the struct wasdefault
. If nullable, then it won't bedefault
and the issue is avoided.