Fix: did not get version number when gw2sharp.dll was included into .… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exe with fody costura * fody costura wraps all .dlls into a single .exe. Because of that the gw2sharp.dll was not accessible. Thus the assembly.Location returned an empty string. This empty string caused .GetVersionInfo to throw a 'System.ArgumentException' in mscorlib.dll with System.ArgumentException: 'The path is not of a legal form.' * fody costura is used by BlishHud for example * try catch is probably not necessary anymore? sources * Fody/Fody#556 * https://www.llblgen.com/tinyforum/Thread/23972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exe with fody costura
sources