Combine shared enums usage #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archomeda
added
Area: Web API v2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40.
After looking through the code, there was no reason why it was done this way. The original intention was to emulate the expected id type in the web API, which is a string (as was done with the race). However, the profession was using an enum type. This introduced inconsistency.
This PR resolves this inconsistency. For easiness, the Mumble Client returns enums now. And the respective endpoints that accept either a legend, profession or race as id, will also accept these enum counterparts.
This is a breaking change, and will be introduced in v0.9.0.