Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception type when the result is not JSON #89

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

Archomeda
Copy link
Owner

Failing API responses that don't have a JSON body currently throw the UnexpectedStatusException which is incorrect if the server responded with e.g. a 500 code. This fixes the exception type to be its proper exception type.

@Archomeda Archomeda added Type: Bug Something isn't working Area: Web API v2 Related to the v2 web API labels Jul 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Archomeda Archomeda merged commit 2e04e82 into master Jul 14, 2021
@Archomeda Archomeda deleted the fix/improper-exception-type-when-not-json branch July 14, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant