Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new legendary armory location enum values #91

Merged
merged 2 commits into from
Jul 17, 2021

Conversation

Archomeda
Copy link
Owner

@Archomeda Archomeda commented Jul 17, 2021

This updates the main character endpoint, and the equipment tab subendpoint to schema 2021-07-15T13:00:00.000Z that includes the EquippedFromLegendaryArmory and LegendaryArmory enum values for the equipment location.

Coincidentally, this also fixes the oversight where the individual character by id endpoint didn't have the latest schema version applied, resulting in Client.Characters["character-name"].GetAsync() using the old schema 2019-12-19T00:00:00.000Z that didn't have the changes of equipment_pvp applied from schema 2021-04-06T21:00:00.000Z.

@Archomeda Archomeda added Type: Feature An addition to the project Area: Web API v2 Related to the v2 web API labels Jul 17, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Archomeda Archomeda merged commit 8cf95e5 into master Jul 17, 2021
@Archomeda Archomeda deleted the feature/add-legendary-armory-location-enum-values branch July 17, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Feature An addition to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant