LogSort: Add sorting by BRD_SER_NUM #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build MissionPlanner 1.0.3000 completed (commit 8dfed58b37 by @TunaLobster) |
|
so the concept is good, the issue is that this is only changing the sitl logs atm, ie to really be usefull needs to include the others as well. i would also add a check for "0" to exclude it |
|
✅ Build MissionPlanner 1.0.3076 completed (commit f1e2c413bf by @TunaLobster) |
|
@meee1 I'm struggling a little bit to get this working in practice. Comments on what I am doing with the code would be helpful. Trying to learn a bit as I go. |
|
This is a great idea! |
meee1
force-pushed
the
pr/sort-by-brdsernum
branch
from
dc1cb6e
to
d2504f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how well this works because I'm not able to get a VS environment set up.
The intent is to also sort log files based on BRD_SER_NUM. There are some uses for that parameter to identify what autopilot was used in which plane. Changes or other ideas are welcome. Maybe SYSID-SER_NUM format?