Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up ConfigRawParams and ConfigRawParamsTree reload time #2753

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

EosBandi
Copy link
Collaborator

A new Planner setting checkbox called "Running on a slow computer" controls how the ConfigRawParams and ConfigRawParamsTree pages are reloaded. If enabled, it keeps the metadata info and refreshes only the values and the control. For safety, there is a button to refresh the whole table (without reloading parameters from the vehicle).

Time improvements: Measured on an Intel Baytrail T Z3735F Quad Core stick computer with 2GB RAM
original Running on Slow Computer
ConfigRawParams reload 13sec 2.4 sec
ConfigRawParamsTree reload 20sec 3.5 sec

Note: Initial opening times of these pages are not improved; that needs a significant rewrite of the ParameterMetadataRpository, which is not in the scope yet.

@AppVeyorBot
Copy link

@meee1
Copy link
Contributor

meee1 commented Dec 20, 2021

this doesn't violate any cross thread gui calls does it? ie the paralell.for's etc would

@EosBandi
Copy link
Collaborator Author

Paralell fors was there, I simply made the rowlist static. None of the two controls are used elsewhere and it just tests OK. So it did not break anything during testing.

@meee1 meee1 merged commit 563ed8d into ArduPilot:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants