-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAVCAN ESCs: add support for reversing motor direction #17497
Comments
I have this working already.... code needs cleanup though |
This is a feature I am interested in adding. I added support for it on my own fork over here , and that seems to be working well enough during my testing with Rover, but I see now that there is an existing pull request as well. I'm happy to work on pushing forward this feature, but I'm new to contributing to ArduPilot, so I had some questions:
|
Hi @iq-fred, A new PR is probably best. I think it would be best to first get the support for reversible DroneCAN motors in and the move onto a separate change to allow Copter to make use of them. So the first stage would be driver changes and testing to ensure that Rover and Plane is improved and Copter (and perhaps other vehicles) are simply not affected. Thanks! |
That sounds good, I'll focus on getting a pull request ready for changes to help out Rover and Plane first. Thanks! |
I've added a pull request to try and address this issue: #24386 |
We should add support for reversing the direction of UAVCAN ESCs. See to-do in the code here.
This was first raised as a request as part of the Rover-4.1.0 beta testing (discussion)
The text was updated successfully, but these errors were encountered: