Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: improve PILOT_SPEED_DN parameter description #19839

Closed
standmit opened this issue Jan 20, 2022 · 3 comments
Closed

Copter: improve PILOT_SPEED_DN parameter description #19839

standmit opened this issue Jan 20, 2022 · 3 comments
Labels

Comments

@standmit
Copy link

Feature request

Is your feature request related to a problem? Please describe.
Special situation when PILOT_SPEED_DN = 0 isn't documented (introduced in #6951). "Oops" happens

Describe the solution you'd like
Special value "0" of PILOT_SPEED_DN parameter should be documented in the parameter description and maybe in AltHold description page.

Describe alternatives you've considered
Alternatively, value "0" should mean "0" but not PILOT_SPEED_UP.

Platform
[ ] All
[ ] AntennaTracker
[ V ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Additional context

// It will return the PILOT_SPEED_DN value if non zero, otherwise if zero it returns the PILOT_SPEED_UP value.
uint16_t Copter::get_pilot_speed_dn() const
{
if (g2.pilot_speed_dn == 0) {
return abs(g.pilot_speed_up);
} else {
return abs(g2.pilot_speed_dn);
}
}

@rmackay9 rmackay9 changed the title Zero PILOT_SPEED_DN situation Copter: improve PILOT_SPEED_DN parameter description Jan 20, 2022
@standmit
Copy link
Author

What steps need to be taken to get this updated description into the QGroundControl?

@rmackay9
Copy link
Contributor

@standmit,

I think 4.2 probably needs to go out as the official release. We're almost there, perhaps 2.5 more weeks.

@IamPete1
Copy link
Member

IamPete1 commented Aug 5, 2022

Fix is merged and 4.2 is out.

@IamPete1 IamPete1 closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants