Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move EKF_GPS_DELAY to GPS library #2850

Closed
rmackay9 opened this issue Sep 15, 2015 · 6 comments
Closed

move EKF_GPS_DELAY to GPS library #2850

rmackay9 opened this issue Sep 15, 2015 · 6 comments
Assignees
Milestone

Comments

@rmackay9
Copy link
Contributor

The EKF has the EKF_POS_DELAY and EKF_VEL_DELAY parameters which should be set based upon the GPS type that is being used. A better solution would be to have these expected delay parameters in the GPS library instead and have the values default set based upon the detected GPS type.

If using a Ublox GPS we'd like the delays to be slightly different for each variety.
6 = 0.22
7 = 0.20
8 = 0.18

@priseborough
Copy link
Contributor

I would recommend starting with

6 = 0.22 (existing default)
7 = 0.20 (what Solo uses)
8 = 0.15 (needs testing)

@ghost
Copy link

ghost commented Sep 15, 2015

Hi all,
these are new and slightly more conservative numbers compared to Paul's initial suggestion of 120ms for the M8.
Re "8 = 0.15 (needs testing)": how should a test look like?
Best regards,
Thorsten

@magicrub
Copy link
Contributor

once known-good values are determined, can these be baked into the GPS
driver?

On Tue, Sep 15, 2015 at 1:53 PM, Thorsten notifications@github.com wrote:

Hi all,
these are new and slightly more conservative numbers compared to Paul's
initial suggestion of 120ms for the M8.
Re "8 = 0.15 (needs testing)": how should a test look like?
Best regards,
Thorsten


Reply to this email directly or view it on GitHub
#2850 (comment)
.

@priseborough
Copy link
Contributor

Perform hard accelerate and stop manoeuvres north-south and east-west. Log the data using the 400Hz data rate option. Replay through the EKF replay and adjust the delay parameters until the magnitude of the EKF3.IPN EKF3.IPE, EKF3.IVN and EKF3.IVE (the GPS position and velocity innovations) is minimised.

I got 0.12 sec from my initial testing, but that was some time ago, so have backed off a bit on the value as it is better to over-estimate rather than under-estimate the delay.

On 16 Sep 2015, at 6:53 am, Thorsten notifications@github.com wrote:

Hi all,
these are new and slightly more conservative numbers compared to Paul's initial suggestion of 120ms for the M8.
Re "8 = 0.15 (needs testing)": how should a test look like?
Best regards,
Thorsten


Reply to this email directly or view it on GitHub #2850 (comment).

@WickedShell
Copy link
Contributor

@magicrub there is a get_lag function in the gps driver ( libraries/AP_GPS/AP_GPS.h#L326 )that currently just returns a value of 0.2 the plan is to allow the drivers to provide a real value that is correct if it knows the hardware version/what it should be (although this is the first time we are explicitly handling hardware version detection in the ublox driver). If the user fills out a value in the GPS_DELAY other then 0 that would be returned rather then the one provided by the driver. (And if detection fails then we return the current default).

At least this is the plan as I understand it. If this is incorrect then someone should stop me before I go do it this way :)

@WickedShell WickedShell added this to the Plane v3.6.0 milestone Apr 18, 2016
@WickedShell WickedShell modified the milestones: Plane v3.6.1, Plane v3.6.0 Jun 6, 2016
@OXINARF OXINARF modified the milestones: Plane v3.6.1, Plane v3.8.0 Sep 28, 2016
@WickedShell
Copy link
Contributor

This went in with #5407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants