Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast takeoff in poshold mode to midair then continue small shift can't hold its position #9442

Closed
askariz opened this issue Sep 18, 2018 · 5 comments

Comments

@askariz
Copy link

askariz commented Sep 18, 2018

Bug report

Issue details

Fast takeoff (First let PILOT_SPEED_UP to 10m/s then full throttle takeoff in poshold mode) in poshold mode to midair then continue small shift can't hold its position !
image

And I find it due to code in mode_poshold.cpp there are 3 call for loiter_nav->init_target();
image

Version
copter-3.6/master

Platform
[ ] All
[ ] AntennaTracker
[ ✔ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Airframe type
hex copter

Hardware type
SITL & PX4-V2

Logs
https://drive.google.com/file/d/1dChBmx2aOMKALWHLzCjgYflMhGAB6Wgg/view

@lthall
Copy link
Contributor

lthall commented Sep 18, 2018

Sorry but it is not clear what you are saying the problem is. I can't even see what you have plotted in your graph.

Could you please attempt to describe this problem in more detail.

@lthall
Copy link
Contributor

lthall commented Sep 18, 2018

Ok, I think I see what you are saying and I think I have fixed the issue.

Could you test this?

https://github.com/lthall/Leonard_ardupilot/tree/20180918-PosHoldFix

Thank you very much for bringing this to our attention!!

@askariz
Copy link
Author

askariz commented Sep 18, 2018

HI , I have tested your commit with SITL then the problem solved .
Thank you .

@lthall
Copy link
Contributor

lthall commented Sep 18, 2018

Thanks!!!

@rmackay9
Copy link
Contributor

fix merged into master and will go out with -rc11.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants