Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRBRAIN - ChibiOS boards configuration #10322

Merged
merged 6 commits into from Jan 24, 2019
Merged

VRBRAIN - ChibiOS boards configuration #10322

merged 6 commits into from Jan 24, 2019

Conversation

LukeMike
Copy link
Contributor

  • Fixed ChibiOS configuration of VR Brain 5.2
  • Added ChibiOS configuration of VR Brain 5.1
  • Added ChibiOS configuration of VR Core 1.0
  • Added ChibiOS configuration of VR Brain 5.4
  • Added VR Brain boards into common_boards of build_binaries

WickedShell
WickedShell reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@WickedShell WickedShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same pins I pointed out also differ in the v52 hwdef from what was defined before in HAL_VRBRAIN

libraries/AP_HAL_ChibiOS/hwdef/VRBrain-v51/hwdef.dat Outdated
define HAL_BUZZER_OFF 0

# battery setup
define HAL_BATT_VOLT_PIN 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under HAL_VRBRAIN this was pin 10, is this correct? (This looks like bad copy paste from FMUv3)

libraries/AP_HAL_ChibiOS/hwdef/VRBrain-v51/hwdef.dat Outdated

# battery setup
define HAL_BATT_VOLT_PIN 2
define HAL_BATT_CURR_PIN 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under HAL_VRBRAIN this was pin -1 (undefined), is this correct? (This looks like bad copy paste from FMUv3)

@tridge
Copy link
Contributor

tridge commented Jan 24, 2019

I've fixed the commit message format, and fixed the voltage and current pins, and force pushed to the PR branch
@LukeMike please check the changes

@LukeMike
Copy link
Contributor Author

@tridge @WickedShell You are right! My mistake, sorry! Thanks very much!

@tridge tridge merged commit ff52cea into ArduPilot:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WickedShell WickedShell WickedShell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukeMike @tridge @WickedShell