Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TradHeli Acro virtual_flybar #10877

Merged
merged 4 commits into from
Jun 4, 2019
Merged

TradHeli Acro virtual_flybar #10877

merged 4 commits into from
Jun 4, 2019

Conversation

MidwestAire
Copy link
Member

This changes the default behavior of acro flight mode for helicopter to use a virtual flybar instead of pure rate control when Acro Trainer is disabled. This does not change the Acro Trainer or the default behavior of acro flight mode for multicopters.

Flight testing has been performed on Copter 3.6 as per the information in this thread on the discuss forum.
https://discuss.ardupilot.org/t/new-ardupilot-acro-vbar-mode-for-helicopters/39544

Copy link
Contributor

@bnsgeyer bnsgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to add additional comments to clarify parts of the new code. Otherwise LGTM.

Copy link
Member

@lvale lvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we discussed, and I'll try to fly it next weekend on the 450.

@bnsgeyer
Copy link
Contributor

@ChristopherOlson any reason why we can't backport to 3.6? Did you experience any conflicts when you pulled it into your 3.6 branch?

@MidwestAire
Copy link
Member Author

@bnsgeyer absolutely no problem at all. It works fine on 3.6 and there was no conflicts. I did not think it to be suitable for backport since it is not a bug fix, but is a feature enhancement. Looking thru the history it looks only bug fixes are usually backported.

@rmackay9 rmackay9 merged commit 4492727 into ArduPilot:master Jun 4, 2019
@rmackay9
Copy link
Contributor

rmackay9 commented Jun 4, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants