-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITL fixs for alpine linux #11871
SITL fixs for alpine linux #11871
Conversation
libraries/AP_Common/missing/fenv.h
Outdated
@@ -46,3 +46,29 @@ inline int fedisableexcept(unsigned int excepts) | |||
} | |||
|
|||
#endif | |||
|
|||
#if (defined(HAVE_FEENABLEEXCEPT) && !HAVE_FEENABLEEXCEPT) && !defined(__APPLE__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this break the build on macos as functions won't be defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless my boolean logic, this won't be define on macos.
But those functions get their own implementation on macos upper on this file
@OXINARF changes done ! |
@tridge Any objection on merging? |
This fix two error when building SITL on Alpine linux, mainly use on docker.
First fix is for feenableexcept that is only present on glibc, as alpine is using musl, I made a workaround with c++11 standard library.
The second fix a missing header.
I will provide the alpine image later. Using alpine allow to shrink docker container with SITL from 68Mo on ubuntu to 10Mo ! That save some trees !