SITL fixs for alpine linux #11871
Merged
SITL fixs for alpine linux #11871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
reviewed
Jul 30, 2019
libraries/AP_Common/missing/fenv.h
Outdated
| @@ -46,3 +46,29 @@ inline int fedisableexcept(unsigned int excepts) | |||
| } | |||
|
|
|||
| #endif | |||
|
|
|||
| #if (defined(HAVE_FEENABLEEXCEPT) && !HAVE_FEENABLEEXCEPT) && !defined(__APPLE__) | |||
There was a problem hiding this comment.
won't this break the build on macos as functions won't be defined?
There was a problem hiding this comment.
Unless my boolean logic, this won't be define on macos.
But those functions get their own implementation on macos upper on this file
OXINARF
requested changes
Jul 30, 2019
OXINARF
reviewed
Jul 30, 2019
|
@OXINARF changes done ! |
OXINARF
approved these changes
Jul 31, 2019
|
@tridge Any objection on merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix two error when building SITL on Alpine linux, mainly use on docker.
First fix is for feenableexcept that is only present on glibc, as alpine is using musl, I made a workaround with c++11 standard library.
The second fix a missing header.
I will provide the alpine image later. Using alpine allow to shrink docker container with SITL from 68Mo on ubuntu to 10Mo ! That save some trees !