Added retries to FRAM init and read #13581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tridge We had some trouble with a CubeOrange with ADSB Carrier Board with lost parameter (default) on ArduPlane 4.0.4. After applying this PR on top of ArduPlane 4.0.4, the problems seems to be gone. |
nexton-winjeel
added a commit
to Winjeel/ardupilot
that referenced
this pull request
Mar 6, 2020
This adds equivalent functionality that was originally added in: ArduPilot#13581
nexton-winjeel
added a commit
to Winjeel/ardupilot
that referenced
this pull request
Mar 6, 2020
This adds equivalent functionality that was originally added in: ArduPilot#13581
nexton-winjeel
added a commit
to Winjeel/ardupilot
that referenced
this pull request
Mar 6, 2020
This adds functionality similar to what was originally added in: ArduPilot#13581
|
this now incorporates many of the changes from @sypaq-nexton from #13621. It adds the retries and crc checks, as well as fixing fujitsu device support |
- added retries on all operations - detect errors with a CRC - fixed detection of fujitsu devices
this saves on flash and prevents confusing results when fram fails
|
@tridge: I've confirmed this works on our custom hardware with a Fujitsu FRAM chip (MB85RS128TY). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix an intermittent issue reported where parameters are lost with FRAM based boards under certain power conditions.
It does 3 things:
The fallbacks are being disabled as they could be causing a board to change between different storage systems on different boots