AP_Mission: Add support for DO_SET_CAM_TRIGG_DIST #13791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKear
force-pushed
the
support_cam_dist.trigger
branch
from
757a66b
to
dcbaa54
Compare
|
Behaviour before this PR was always: This PR now gives the option to have this behaviour: |
tridge
reviewed
Mar 23, 2020
|
better to trigger immediately and avoid the extra var |
MattKear
force-pushed
the
support_cam_dist.trigger
branch
from
dcbaa54
to
1fe3a89
Compare
|
Simplified this PR as requested/suggested. |
tridge
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the trigger parameter already available as the 3rd packet in DO_SET_CAM_TRIGG_DIST.
Now, if the packet 3 of DO_SET_CAM_TRIGG_DIST is set to 1, it will trigger the camera once, immediately upon recieving the command. This is oppose to the current behaviour in which the first image is taken after the predefined distance has been covered.
This addresses the feature request raised in #13779
Tested in SITL.