Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Landing: option to keep landing throttle at thr_min during flare #14387

Merged

Conversation

davidbuzz
Copy link
Collaborator

No description provided.

@davidbuzz davidbuzz requested a review from tridge May 18, 2020 05:02
ArduPlane/servos.cpp Outdated Show resolved Hide resolved
ArduPlane/servos.cpp Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.cpp Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.cpp Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.cpp Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.h Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.h Outdated Show resolved Hide resolved
libraries/AP_Landing/AP_Landing.h Outdated Show resolved Hide resolved
@davidbuzz davidbuzz force-pushed the landing-flare-honor-min-throttle-in-auto-pr branch 2 times, most recently from f1769eb to 1ebcc12 Compare May 18, 2020 06:55
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs split to 2 commits

@davidbuzz davidbuzz force-pushed the landing-flare-honor-min-throttle-in-auto-pr branch from 1ebcc12 to 4ceee26 Compare May 18, 2020 06:58
@davidbuzz
Copy link
Collaborator Author

needs split to 2 commits

done.

@tridge
Copy link
Contributor

tridge commented May 18, 2020

CI fail:
Parameters (Test Parameter Set/Get) (Downloaded parameters missing in XML) (see /home/travis/build/ArduPilot/buildlogs/QuadPlane-Parameters.txt)

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the CI issues

libraries/AP_Landing/AP_Landing.cpp Outdated Show resolved Hide resolved
@davidbuzz davidbuzz force-pushed the landing-flare-honor-min-throttle-in-auto-pr branch from 4ceee26 to a27f4e9 Compare May 18, 2020 11:08
@tridge tridge merged commit d4df145 into ArduPilot:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants