-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub: Improvements to depth hold, new depth hold tests #15247
Sub: Improvements to depth hold, new depth hold tests #15247
Conversation
8b68aaa
to
57ed261
Compare
422915f
to
850596d
Compare
Open a separate pr to add position_control.get_throttle_output, and use that in place of motors.get_throttle_input please. |
850596d
to
1b054df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is best to keep passing the throttle through the attitude controller to keep consistent with Copter.
f609407
to
37105cc
Compare
86472f7
to
ce5c7c7
Compare
eba71a6
to
6e92ac1
Compare
6e92ac1
to
4ae510f
Compare
4ae510f
to
529e6b6
Compare
496a181
to
0703d6c
Compare
0703d6c
to
c1dbed5
Compare
e837e8c
to
9bdc340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
With this implementation (same as copter's) 1450 is within the pilot deadzone, which breaks the test.
9bdc340
to
b03a5a5
Compare
Thanks for the reviews. I addressed Randy's review. |
Before:
Note that it was moving upwards with the throttle down.
After:
Another noticeable change is that when climbing/diving Alt and DAlt do not match anymore. That is because the old code just applied thrust and relaxed the controller (basically doing
DAlt = Alt
).This still needs real life testing to make sure that response is not too sluggishI tested on a BlueROV2 and it feels good.
Log:
00000001.zip