Add concept of bus ownership to SITL i2c simulation #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/sitl-i2c-ownership
branch
from
f5efa69
to
5e3ebd8
Compare
peterbarker
force-pushed
the
pr/sitl-i2c-ownership
branch
from
5e3ebd8
to
8b71872
Compare
Also stop copying the bus object while iterating
Not sure the initialisation is needed but retained it.
peterbarker
force-pushed
the
pr/sitl-i2c-ownership
branch
from
8b71872
to
6da6105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bus ownership check isn't that useful ATM as we don't run separate threads for the buses in SITL. It will catch cases where a driver being initialised doesn't take the bus semaphore, however.
Also initialise the simulated i2c bus count (not used from a technical perspective ATM)
Also don't allow copies of Semaphore objects to be created.
Correct taking copy of SITL I2C bus when iterating through the list.