Rover (sailboat), true wind if no windspeed sensor, bug fixed #17432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meholden Looks correct to me, Thanks for the PR! Just need to update the commit message, they should start with the name of the library (or vehicle). E.G. |
I am bad with git but I did do this I think. |
|
@meholden thanks! you got the commit message right but also got some extra commits, I have fixed it for you. Should be good to merge once it get through the checks. |
|
I made the same mistake on speed, I have added a commit to fix that bug too. |
IamPete1
approved these changes
May 16, 2021
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation for true wind direction in the case where the boat does not have a wind speed sensor had a bug. It used the wrong variable (filtered not raw) and did not wrap the angle calculation. Because the raw direction was not calculated, the filter later in the code calculates 0 for true wind. I tested both the original and fixed versions on my boat with an analog wind vane and it works for me.