AP_GPS: Novatel enhancements #17744
Merged
AP_GPS: Novatel enhancements #17744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also wrap up some common whitespace issues
khancyr
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Changes looks good. I didn't test as I don't have the hardware.
We could rebase and benefit from https://github.com/ArduPilot/ardupilot/pull/18916/files to have some testing and surely modify the test to have the autoconfigure testing too.
tridge
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two functional things to the Novatel driver:
GPS_AUTO_CONFIGparameterThere are also a number of whitespace changes that are to try and bring things a bit closer to the standard style we use (there's a lot more that can be done here, but I've left that for another day).
This was bench tested against real hardware.