Plane: Quadpalne: move tiltrotor functionality to own class #18579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
tiltrotor_class
branch
3 times, most recently
from
d81da5e
to
e1ce903
Compare
|
All seems to work as expected with the Griffin in RF |
IamPete1
force-pushed
the
tiltrotor_class
branch
from
e1ce903
to
921b352
Compare
|
rebased on mode changes and re-tested param conversion. |
tridge
requested changes
Sep 13, 2021
IamPete1
force-pushed
the
tiltrotor_class
branch
2 times, most recently
from
2c29127
to
e447308
Compare
tridge
previously requested changes
Sep 16, 2021
There was a problem hiding this comment.
@IamPete1 testing fails badly on Griffin model in RF9. The motors end up tilting down:
it tries to take off like that and does a nose down
parameters attached
griffin.txt
IamPete1
force-pushed
the
tiltrotor_class
branch
from
e447308
to
d1c7797
Compare
IamPete1
force-pushed
the
tiltrotor_class
branch
from
d1c7797
to
8e3b5a8
Compare
|
I had "fixed" all of those I have done it properly now. |
tridge
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes quadplane slightly cleaner and lets us hide tilt params. Removes remaining confusion between tailsitters and tiltrotors.