New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripting: implement a tilting rudder as a lua script #21148
Conversation
New bindings work great in this use case. My concern would be that someone tries to use them in another case. They will be nonsense in fixed wing flight just never updating and they bypass the spool logic. As I say this case is fine, but if someone were to implement a mixer with motors they would probably have a bad time. We do have the servo output functions for rate output, but they only include feed forward. We could add some that are feed forward and rate I guess. But again If someone were to use them for motors they would probably have a bad time. You could calculate the yaw output from the motor pwms. But that is a fair bit of extra effort. I would like to include control surfaces and tilting motors into the/a quadratic programming mixer eventually. Such scailing as this would just fall out of the maths. |
b8bf5ba
to
143e151
Compare
Recently used this on a tilt-rotor copter, worked great. There are a couple of things it needs. Firstly I had to grab average throttle to do thrust scaling, as a hack I was able to grab throttle from the boost motor servo output with a scale of 1. So a binding for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider getting the bindings at least into 4.3 for this.
I think this needs limit flags, throttle and spool state. I have added here: https://github.com/IamPete1/ardupilot/tree/tilt_rudder%2Bthrottle%2Blimits Throttle, forward and lateral are needed for doing motors. As its spool state: 0faa6c9 |
143e151
to
d7d3c7a
Compare
@IamPete1 I've incorporated your additions in this PR |
…l state from motors
d7d3c7a
to
fb7bda9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but then again 3/4 of the commits are mine. ;)
For vehicles with rudders on tilting motors, which should be fixed wing rudder in fwd flight and VTOL rudder in hover