Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRV_Channel: pwm_from_angle: return trim for 0 high_out #22015

Merged
merged 1 commit into from Oct 25, 2022

Conversation

IamPete1
Copy link
Member

When changing output function from disabled to scaled output high_out is zero until we call update_aux_servo_function which is done a a lower rate than the outputs. So we end up with a divide by 0 for a few loops.

pwm_from_range already checks for high_out of 0.

#21347 (although I suspect setting a function to scaled output is not the only way to hit this.)

Found when checking we can do full range servo for #22011

@tridge tridge merged commit 5382083 into ArduPilot:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants