SRV_Channel: pwm_from_angle: return trim for 0 high_out #22015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing output function from disabled to scaled output
high_out
is zero until we callupdate_aux_servo_function
which is done a a lower rate than the outputs. So we end up with a divide by 0 for a few loops.pwm_from_range
already checks forhigh_out
of 0.#21347 (although I suspect setting a function to scaled output is not the only way to hit this.)
Found when checking we can do full range servo for #22011