Plane: Quadplane: remove RTL navigate incorrect comment and unneeded… #22492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraigElder
changed the title
tridge
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… check
This comment and check was added by me at some point in the past. I'm not sure if it was ever correct, it certainty is not now. Navigate is only called from the mode pointer here:
ardupilot/ArduPlane/navigation.cpp
Line 109 in ec0b51d
So it is not possible to call the RTL navigate from QRTL mode. Possibly in the past we were calling the RTL mode function directly. Tested by adding a panic if in QRTL mode and running the quadplane autotest.